-
Notifications
You must be signed in to change notification settings - Fork 62.3k
workspaceFolder is not supported yet #578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
@mtsmfm Thank you so much for opening a PR! I'll get this triaged for review ⚡ |
@matthewisabel, there are several properties in this list that are not supported in Codespaces: Not yet supported
Not applicable for Codespaces (no plan to support)
VS Code's devcontainer documentation is closer to being correct -- there are some comments about which properties are not supported in Codespaces or if they behave slightly differently in Codespaces: https://code.visualstudio.com/docs/remote/devcontainerjson-reference cc @Chuxel |
This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit. |
@janiceilene @jkeech I've updated the doc to follow the comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for letting us know about these unsupported keys! I added a few suggested changes for the best way to convey that information. After you commit those suggestions, I can approve and merge! 😎 🎉
content/github/developing-online-with-codespaces/configuring-codespaces-for-your-project.md
Outdated
Show resolved
Hide resolved
content/github/developing-online-with-codespaces/configuring-codespaces-for-your-project.md
Outdated
Show resolved
Hide resolved
…odespaces-for-your-project.md Co-authored-by: Laura Coursen <[email protected]>
…odespaces-for-your-project.md Co-authored-by: Laura Coursen <[email protected]>
@lecoursen Applied your suggestions |
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. |
Why:
https://github.community/t/workspacefolder-setting-doesnt-work/137894
I read this doc and I thought I can use it but actually it doesn't work yet.
What's being changed:
Before
https://docs.github.com/en/free-pro-team@latest/github/developing-online-with-codespaces/configuring-codespaces-for-your-project#supported-codespace-configuration-keys
After
https://docs-578--patch-1.herokuapp.com/en/free-pro-team@latest/github/developing-online-with-codespaces/configuring-codespaces-for-your-project#supported-codespace-configuration-keys
Check off the following: